Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove calls to APIs deprecated in version 12.6 and removed in 12.7 #185

Merged
merged 1 commit into from
May 14, 2024
Merged

Remove calls to APIs deprecated in version 12.6 and removed in 12.7 #185

merged 1 commit into from
May 14, 2024

Conversation

ajklein
Copy link
Member

@ajklein ajklein commented May 14, 2024

Update ScriptOrigin constructors to remove unused Isolate argument and
delete reference to no-op SafeForTerminationScope and related Isolate param.

@ajklein ajklein requested a review from syg May 14, 2024 19:49
@syg
Copy link

syg commented May 14, 2024

This is to pre-emptively unbreak the our CI, right? What's the plan wrt upstream?

@ajklein
Copy link
Member Author

ajklein commented May 14, 2024

Yes, this is just to be able to land the removal through the CQ.

Given the trivial nature of these updates I wasn't planning to do anything upstream, but I could file an issue linking to this PR if you think that'd be worthwhile. I'm not opposed to making an upstream PR myself, but I'll bet regular Node contributors would be more efficient than I. WDYT?

@ajklein ajklein merged commit abd9454 into v8:node-ci-2024-04-23 May 14, 2024
12 of 15 checks passed
@ajklein ajklein deleted the 2024-05-14_update_script_origin branch May 14, 2024 20:54
@syg
Copy link

syg commented May 14, 2024

Given the trivial nature of these updates I wasn't planning to do anything upstream, but I could file an issue linking to this PR if you think that'd be worthwhile. I'm not opposed to making an upstream PR myself, but I'll bet regular Node contributors would be more efficient than I. WDYT?

Filing an issue SGTM. They've been pretty fast to respond recently.

@ajklein ajklein mentioned this pull request May 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syg syg syg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajklein @syg